-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redo validation for fields #630
Conversation
redid the pr + added the __typename to one of the tests. |
Jap, saw it! Sorry, short on time currently. Not forgotten, it's in the queue! |
Awesome, keep up the good work 💪 |
Sorry for the late feedback; I hope I'll find more time this week. At a first glance however, I hesitated to go through the whole PR again because the commit messages and changes would kind of require that. My sincere suggestion would be to make this PR a bit simpler to review:
The goal would be: since I already reviewed the original PR, I've less overhead and can concentrate more on the "delta" and knowing that the other commit is an (untouched) revert. This also has other benefits like providing a very clear git history on its own without depending on the conversation here on github (not that this is mandatory, but it really makes the whole thing within just the git repo itself transparent). I again apologize for the delay and that I ask of this now that the PR is laying around for over a month, but what you consider this? (totally fine for me to force-push this over this PR). |
This reverts commit fb9dace.
ac839de
to
c48de40
Compare
separated the __typename fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-) 👍
Summary
Fixes #602
Rules never worked in field arguments. (redone)
Type of change
Checklist
composer fix-style